Skip to content

Fixes #114 by removing the outdated test in the TCK and adding guideline... #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2014

Conversation

viktorklang
Copy link
Contributor

... for cancellation propagation for Processor to the README.

See #114

@viktorklang
Copy link
Contributor Author

Ping @reactive-streams/contributors

@benjchristensen
Copy link
Contributor

s/upsteam/upstream a typo.

Agreed on removing the test. Not sure I understand why the appendix addition is needed or beneficial. Lots of choices exist when implementing this stuff, we don't need to itemize them.

@viktorklang
Copy link
Contributor Author

@benjchristensen upsteam sounds a bit cool tho...

The appendix addition is definitely useful for implementors that may or may not know what can be done.
Since it is rather clear that it is not a spec rule I see no harm in adding it. @smaldini asked to have it added so he'll probably want to comment.

…ine for cancellation propagation for Processor to the README.
@ktoso
Copy link
Contributor

ktoso commented Oct 1, 2014

I agree that deleting that one makes sense, thanks @viktorklang.
No hard feelings on the appendix though - maybe it would become a tips section at some point rather than a sentence here. For now is fine as is IMO.

@viktorklang
Copy link
Contributor Author

16 days later, ping @reactive-streams/contributors

@benjchristensen
Copy link
Contributor

It's fine to commit ... agree with this sentiment -> "maybe it would become a tips section at some point rather than a sentence here"

@jbrisbin
Copy link

👍

@viktorklang
Copy link
Contributor Author

@benjchristensen Absolutely. It would be great to have an "Implementor's Notes" document.

viktorklang added a commit that referenced this pull request Oct 24, 2014
Fixes #114 by removing the outdated test in the TCK and adding guideline...
@viktorklang viktorklang merged commit 20b6e76 into master Oct 24, 2014
@viktorklang viktorklang deleted the wip-fix-114-√ branch October 24, 2014 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants